Skip to content

fix backup repo connect #464

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
kaovilai wants to merge 17 commits into
base: oadp-dev
Choose a base branch
from
Draft

fix backup repo connect #464

kaovilai wants to merge 17 commits into from
+647 −20

Conversation

@kaovilai
Copy link
Member

@kaovilai kaovilai commented Nov 7, 2025

  • Add design doc
  • Update design
  • New design doc
  • Enhance wildcard namespace support in backup and restore design document
  • Refine wildcard namespace support design document
  • Enhance wildcard namespace support design document
  • Update design
  • Status fields are part of a struct
  • Added struct change
  • Updates
  • update
  • Leaner design
  • Simplify
  • repo provider interface refactor for repo static configuration
  • Fix PrepareRepo to ensure local config file is created when repository exists remotely, addressing failures in multi-pod environments and after pod restarts.

Thank you for contributing to Velero!

Please add a summary of your change

Does your change fix a particular issue?

Fixes #(issue)

Please indicate you've done the following:

Joeavaikath and others added 17 commits August 19, 2025 17:44
@Joeavaikath
Add design doc
571a816 
Signed-off-by: Joseph <[email protected]>
@Joeavaikath
Update design
69e3079 
Signed-off-by: Joseph <[email protected]>
@Joeavaikath
New design doc
c0699c4 
Signed-off-by: Joseph <[email protected]>
@Joeavaikath
Enhance wildcard namespace support in backup and restore design document
4c1457c 
- Updated the abstract to clarify the current limitations of namespace specifications in Velero.
- Expanded the goals section to include specific objectives for implementing wildcard patterns in `--include-namespaces` and `--exclude-namespaces`.
- Detailed the high-level design and implementation steps, including the addition of new status fields in the backup CRD and the creation of a utility package for wildcard expansion.
- Addressed backward compatibility and known limitations regarding the use of wildcards alongside the existing "*" character.

This update aims to provide a comprehensive overview of the proposed changes for improved namespace selection flexibility.

Signed-off-by: Joseph <[email protected]>
@Joeavaikath
Refine wildcard namespace support design document
037db22 
- Clarified the use of the standalone `*` character in namespace specifications.
- Ensured consistent formatting for `*` throughout the document.
- Maintained focus on backward compatibility and limitations regarding wildcard usage.

This update enhances the clarity and consistency of the design document for implementing wildcard namespace support in Velero.

Signed-off-by: Joseph <[email protected]>
@Joeavaikath
Enhance wildcard namespace support design document
571c9bd 
- Expanded the design to include detailed implementation steps for wildcard expansion in both backup and restore operations.
- Added new status fields to the backup and restore CRDs to track expanded wildcard namespaces.
- Clarified the approach to ensure backward compatibility with existing `*` behavior.
- Addressed limitations and provided insights on restore operations handling wildcard-expanded backups.

This update aims to provide a comprehensive and clear framework for implementing wildcard namespace support in Velero.

Signed-off-by: Joseph <[email protected]>
@Joeavaikath
Update design
eb8b382 
Signed-off-by: Joseph <[email protected]>
@Joeavaikath
Status fields are part of a struct
56df64b 
Signed-off-by: Joseph <[email protected]>
@Joeavaikath
Added struct change
528392a 
Signed-off-by: Joseph <[email protected]>
@Joeavaikath
Updates
0b40702 
Signed-off-by: Joseph <[email protected]>
@Joeavaikath
update
14a6315 
Signed-off-by: Joseph <[email protected]>
@Joeavaikath
Leaner design
cf7a949 
Signed-off-by: Joseph <[email protected]>
@Joeavaikath
Simplify
75f1817 
Signed-off-by: Joseph <[email protected]>
@Lyndon-Li
repo provider interface refactor for repo static configuration
9556a39 
Signed-off-by: Lyndon-Li <[email protected]>
@Lyndon-Li
Merge pull request vmware-tanzu#9379 from Lyndon-Li/repo-static-info-…
d4a9664 
…provider

Repo provider interface refactor for repo static configuration
@blackpiglet
Merge pull request vmware-tanzu#9057 from Joeavaikath/feat/wildcard-n…
9e5769c 
…amespaces

Design: Feat/wildcard namespaces
@kaovilai
Fix PrepareRepo to ensure local config file is created when repositor…
08fc1b9 
…y exists remotely, addressing failures in multi-pod environments and after pod restarts.

Signed-off-by: Tiger Kaovilai <[email protected]>
@openshift-ci
Copy link

openshift-ci bot commented Nov 7, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 7, 2025
@openshift-ci
Copy link

openshift-ci bot commented Nov 7, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kaovilai

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 7, 2025
@coderabbitai
Copy link

coderabbitai bot commented Nov 7, 2025

Important

Review skipped

Auto reviews are limited based on label configuration.

🚫 Excluded labels (none allowed) (1)
  • do-not-merge/work-in-progress

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Comment @coderabbitai help to get the list of available commands and usage tips.

1 similar comment
@coderabbitai
Copy link

coderabbitai bot commented Nov 7, 2025

Important

Review skipped

Auto reviews are limited based on label configuration.

🚫 Excluded labels (none allowed) (1)
  • do-not-merge/work-in-progress

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 13, 2025
@openshift-merge-robot
Copy link

openshift-merge-robot commented Nov 13, 2025

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Awaiting requested review from Copilot Copilot will automatically review once the pull request is marked ready for review

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@kaovilai @openshift-merge-robot @Joeavaikath @Lyndon-Li @blackpiglet