-
Notifications
You must be signed in to change notification settings - Fork 19
Remove unused CODEGEN_VERSION from Makefile.prow #392
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: oadp-dev
Are you sure you want to change the base?
Conversation
The CODEGEN_VERSION variable was defined but not used anywhere in the Makefile.prow file or the rest of the repository. Fixes openshift#363 Signed-off-by: Tiger Kaovilai <[email protected]>
4af10f7 to
90a1886
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kaovilai, sseago The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@kaovilai: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
Issues go stale after 90d of inactivity. Mark the issue as fresh by commenting If this issue is safe to close now please do so with /lifecycle stale |
|
Stale issues rot after 30d of inactivity. Mark the issue as fresh by commenting If this issue is safe to close now please do so with /lifecycle rotten |
WalkthroughRemoved the unused CODEGEN_VERSION variable assignment (CODEGEN_VERSION := 0.22.2) from Makefile.prow, as this variable is no longer referenced in the build system. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Assessment against linked issues
✨ Finishing touches🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro Cache: Disabled due to data retention organization setting Knowledge base: Disabled due to 📒 Files selected for processing (1)
💤 Files with no reviewable changes (1)
Comment |
Summary
Removes the unused
CODEGEN_VERSIONvariable fromMakefile.prowthat was defined but never referenced.Details
CODEGEN_VERSION := 0.22.2variable was defined on line 14 ofMakefile.prowTesting
make --dry-runCODEGEN_VERSIONexist in the repositoryFixes #363