Skip to content

Conversation

@mpryc
Copy link

@mpryc mpryc commented May 19, 2025

Use of downstream fork of the Kopia repository.

This is required as well as:
openshift/oadp-operator#1759

Why the changes were made

Fix: OADP-6141

How to test the changes made

Check the go.mod it should point to migtools/kopia.

Use of downstream fork of the Kopia repository.

Signed-off-by: Michal Pryc <[email protected]>
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label May 19, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented May 19, 2025

@mpryc: This pull request references OADP-6141 which is a valid jira issue.

In response to this:

Use of downstream fork of the Kopia repository.

This is required as well as:
openshift/oadp-operator#1759

Why the changes were made

Fix: OADP-6141

How to test the changes made

Check the go.mod it should point to migtools/kopia.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci
Copy link

openshift-ci bot commented Jul 30, 2025

@mpryc: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-ci
Copy link

openshift-ci bot commented Jul 30, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kaovilai, mpryc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 30, 2025
@openshift-bot
Copy link

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@openshift-ci openshift-ci bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Oct 29, 2025
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 29, 2025
@openshift-merge-robot
Copy link

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-bot
Copy link

Stale issues rot after 30d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle rotten
/remove-lifecycle stale

@openshift-ci openshift-ci bot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Nov 29, 2025
@coderabbitai
Copy link

coderabbitai bot commented Nov 29, 2025

Walkthrough

Updated the go.mod module replacement for Kopia, switching the source from the Velero fork to the MigTools fork while maintaining the same pseudo-version.

Changes

Cohort / File(s) Summary
Dependency Management
go.mod
Updated Kopia module replacement from Velero fork to MigTools fork with identical pseudo-version

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

This is a straightforward module replacement change with minimal risk. The update maintains the same version across forks, reducing the likelihood of compatibility issues.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

Cache: Disabled due to data retention organization setting

Knowledge base: Disabled due to Reviews -> Disable Knowledge Base setting

📥 Commits

Reviewing files that changed from the base of the PR and between 56ba9c6 and 96b5bd1.

⛔ Files ignored due to path filters (1)
  • go.sum is excluded by !**/*.sum
📒 Files selected for processing (1)
  • go.mod (1 hunks)
🧰 Additional context used
📓 Path-based instructions (1)
**

⚙️ CodeRabbit configuration file

-Focus on major issues impacting performance, readability, maintainability and security. Avoid nitpicks and avoid verbosity.

Files:

  • go.mod
🔇 Additional comments (1)
go.mod (1)

199-199: Based on my verification attempts, I've discovered a critical discrepancy that affects the review comment's validity:

Key Finding: Web searches show conflicting results about the migtools/kopia fork:

  • Initial search suggests the fork exists and is documented in OADP
  • Subsequent search cannot locate the fork or the commit hash 20bfabbfc7a0 in any public repository
  • The referenced issue OADP-6141 appears to be a private tracker (not public GitHub)

This means the original review comment's verification requests are actually critical and justified — the fork legitimacy cannot be confirmed through public channels.

Here is the rewritten review comment:


Verify fork existence and stability before merge.

The module replacement syntax is syntactically correct. However, the fork github.com/migtools/kopia cannot be verified in public repositories, and the commit hash 20bfabbfc7a0 is not found in standard Git searches. The referenced issue OADP-6141 appears to be a private tracker. Before merging, confirm:

  1. The github.com/migtools/kopia fork is accessible and actively maintained (public or private)
  2. The commit hash 20bfabbfc7a0 exists in the fork
  3. CI/CD pipeline passes with this replacement
  4. All transitive dependencies resolve correctly
  5. This fork strategy is not a temporary workaround without long-term support plan

The PR references a coordinated oadp-operator change, suggesting a legitimate use case, but public verification is not possible without repository access.



Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants