-
Notifications
You must be signed in to change notification settings - Fork 39
add a section about local access in the Cloudflare bindings documentation #167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
…tion add a section to the Cloudflare bindings documentation, documenting that: - bindings can be used both for dev and preview (this is already stated in the get started guide but I believe that it should also be included in the bindings documentation as well) - add information on remote bindings and how people can used them
4adf039
to
46956f1
Compare
@@ -51,6 +51,35 @@ This will generate a `d.ts` file and save it to `worker-configuration.d.ts`. | |||
|
|||
To ensure that your types are always up-to-date, make sure to run `wrangler types --env-interface CloudflareEnv` after any changes to your config file. | |||
|
|||
## Local access to bindings |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: "Local access to bindgins" sounds confusing vs the following "Remote bindings"
Maybe
## Access to bindings
### Local bindings
### Remote bindings
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The issue is that this talks about remote bindings accessible locally, with the structure you're proposing, doesn't that make it sound like remote bindings accessible in your remote worker?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have suggested a few simplifications, feel free to use or not.
Maybe add a common use case: use a prod DB during build when the cached pages are generated
Co-authored-by: Victor Berchet <[email protected]>
Co-authored-by: Victor Berchet <[email protected]>
That's a good point, I actually haven't mentioned build at all, how does this look to you? |
add a section to the Cloudflare bindings documentation, documenting that:
Fixes opennextjs/opennextjs-cloudflare#457