8294399: (ch) Refactor some methods out of sun.nio.ch.UnixFileDispatcherImpl

[bplb]

Interpose a new class sun.nio.ch.UnixDispatcher between sun.nio.ch.NativeDispatcher and its current subclasses sun.nio.ch.DatagramDispatcher and sun.nio.ch.SocketDispatcher; refactor some methods out of sun.nio.ch.UnixFileDispatcherImpl into this updated hierarchy.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8294399: (ch) Refactor some methods out of sun.nio.ch.UnixFileDispatcherImpl

Reviewers

• Alan Bateman (@AlanBateman - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/10434/head:pull/10434
$ git checkout pull/10434

Update a local copy of the PR:
$ git checkout pull/10434
$ git pull https://git.openjdk.org/jdk pull/10434/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 10434

View PR using the GUI difftool:
$ git pr show -t 10434

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/10434.diff

[bridgekeeper]

👋 Welcome back bpb! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@bplb The following label will be automatically applied to this pull request:

• nio

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 03: Full - Incremental (ab83200d)
• 02: Full - Incremental (b66ff40e)
• 01: Full - Incremental (a16bc10a)
• 00: Full (92dfca5f)

[bridgekeeper]

@bplb This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

[bplb]

Ping.

[openjdk]

@bplb This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8294399: (ch) Refactor some methods out of sun.nio.ch.UnixFileDispatcherImpl

Reviewed-by: alanb

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 25 new commits pushed to the master branch:

• a8450b3: 8295713: runtime/ParallelLoad/SuperWait/SuperWaitTest.java fails intermittently on Windows
• 46e6aee: 8295823: Use enhanced-for cycle instead of Enumeration in java.naming
• 8e5d680: 8293093: NPE in P11KeyStore.getID
• 3135914: 8265441: IGV: select block nodes by clicking on it
• 78454b6: 8295879: JFR: Remove warnings in the jdk.jfr module
• 33ff80d: 8295402: G1: Tighten assertion in G1ScanHRForRegionClosure::scan_heap_roots
• 303548b: 8294752: G1: Remove redundant checks in check_obj_during_refinement
• cf121df: 8295889: NMT preinit code does not handle allocation errors
• 772be2e: 8295868: 32-bit Windows build failures after JDK-8294466
• e173fd7: 8295885: GHA: Bump gcc versions
• ... and 15 more: https://git.openjdk.org/jdk/compare/af2de975cbc46ad91c736b110a2212cd32ba60a7...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[bplb]

/integrate

[openjdk]

Going to push as commit d667895.
Since your change was applied there have been 31 commits pushed to the master branch:

• 628820f: 8283093: JMX connections should default to using an ObjectInputFilter
• 521e712: 8286431: Do not use resource array in posix mmap_attach_shared()
• 4d9a1cd: 8292159: TYPE_USE annotations on generic type arguments of record components discarded
• 210fe49: 6244831: JFileChooser does not have tooltip for Desktop, Recent etc ToggleButton on Windows Look and feel
• c2d7a35: 8269235: serviceability/sa/ClhsdbJstackXcompStress.java timed out
• 58a7141: 8295066: Folding of loads is broken in C2 after JDK-8242115
• a8450b3: 8295713: runtime/ParallelLoad/SuperWait/SuperWaitTest.java fails intermittently on Windows
• 46e6aee: 8295823: Use enhanced-for cycle instead of Enumeration in java.naming
• 8e5d680: 8293093: NPE in P11KeyStore.getID
• 3135914: 8265441: IGV: select block nodes by clicking on it
• ... and 21 more: https://git.openjdk.org/jdk/compare/af2de975cbc46ad91c736b110a2212cd32ba60a7...master

Your commit was automatically rebased without conflicts.

[openjdk]

@bplb Pushed as commit d667895.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.