Skip to content

Feature Request: Exception Handling for OpenFGA Client Errors (e.g., TupleAlreadyExistsException) #113

@ankit-sapkota

Description

@ankit-sapkota

Overview

When working with the OpenFGA client, errors such as ExecutionException with FgaApiValidationError as the cause make it difficult to pinpoint specific issues. For example, writing a tuple that already exists throws a generic error, requiring manual parsing of the underlying message to identify the cause.

Problem

Currently, developers must manually parse the error message to determine the specific cause, like a duplicate tuple. This approach adds complexity and can lead to mistakes when handling multiple error types.

Proposed Solution

Introduce custom exceptions (e.g., TupleAlreadyExistsException, InvalidTupleFormatException) that allow developers to handle specific errors directly without parsing error messages.

Benefits

  • Simplifies error handling by catching specific exceptions.
  • Improves code readability and maintainability.
  • Reduces the risk of incorrect error handling due to manual parsing.

Current Workaround

FgaApiValidationError error = (FgaApiValidationError) e.getCause();
String responseData = error.getResponseData();

ObjectMapper objectMapper = new ObjectMapper();
Map<String, Object> responseMap = null;
try {
    responseMap = objectMapper.readValue(responseData, new TypeReference<>() {});
} catch (JsonProcessingException ex) {
    throw new CustomException("Failed to parse response from openfga");
}

String message = (String) responseMap.get("message");
if (message.startsWith("cannot write a tuple which already exists:")) return;

Improved Solution

With custom exceptions like TupleAlreadyExistsException, the error handling could be simplified:

try {
    // Write tuple
} catch (ExecutionException e) {
    TupleAlreadyExistsException cause =e.getCause();
}

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    Status

    Backlog

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions