Skip to content

Conversation

@rhamzeh
Copy link
Member

@rhamzeh rhamzeh commented Aug 13, 2025

Description

Bumps OpenFGA to v1.9.4 which has a fix for a regression in OIDC validation when the audience is not set

What problem is being solved?

How is it being solved?

What changes are made to solve it?

References

closes #240

Review Checklist

  • I have clicked on "allow edits by maintainers".
  • I have added documentation for new/changed functionality in this PR or in a PR to openfga.dev [Provide a link to any relevant PRs in the references section above]
  • The correct base branch is being used, if not main
  • I have added tests to validate that the change in functionality is working as expected

Summary by CodeRabbit

  • Chores
    • Bumped chart version to 0.2.41.
    • Updated default application version to v1.9.4 for deployments.
    • No changes to values, dependencies, or annotations; existing configurations remain compatible.
    • Installing or upgrading the chart now deploys the latest application patch release.
    • Safe to upgrade using your standard Helm upgrade process.

@rhamzeh rhamzeh requested review from a team as code owners August 13, 2025 16:20
@coderabbitai
Copy link

coderabbitai bot commented Aug 13, 2025

Walkthrough

Updated Helm chart metadata in charts/openfga/Chart.yaml: bumped chart version from 0.2.40 to 0.2.41 and appVersion from v1.9.3 to v1.9.4. No other changes.

Changes

Cohort / File(s) Summary
Helm chart metadata
charts/openfga/Chart.yaml
Bump version 0.2.40 → 0.2.41 and appVersion "v1.9.3" → "v1.9.4".

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

Suggested reviewers

  • ttrzeng
✨ Finishing Touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch release/openfga-v1.9.4

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbitai help to get the list of available commands.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Status, Documentation and Community

  • Visit our Status Page to check the current availability of CodeRabbit.
  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@rhamzeh rhamzeh merged commit ad7e1a3 into main Aug 13, 2025
9 of 10 checks passed
@rhamzeh rhamzeh deleted the release/openfga-v1.9.4 branch August 13, 2025 16:24
Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 87c202e and 1b1633a.

📒 Files selected for processing (1)
  • charts/openfga/Chart.yaml (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
  • GitHub Check: lint-test

Comment on lines +6 to +7
version: 0.2.41
appVersion: "v1.9.4"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Verification agent

🧩 Analysis chain

Version and appVersion bump LGTM; verify image tag alignment and Artifact Hub notes.

Patch bump of chart version to 0.2.41 alongside appVersion v1.9.4 is consistent. Please verify that:

  • values.yaml image.tag (if pinned) and any template references don’t still point to v1.9.3.
  • Templates use .Chart.AppVersion or the value override consistently.
  • README/CHANGELOG and Artifact Hub changes are updated to reflect the bump.

Run the following checks from the repo root to catch any stale references and confirm how the image tag is sourced:

Optionally, consider adding Artifact Hub “changes” for better visibility (minor nit):

annotations:
  artifacthub.io/changes: |
    - kind: changed
      description: Update OpenFGA to v1.9.4

To confirm if 1.9.4 requires any chart tweaks (env flags, ports, migrations), fetch release notes:


🏁 Script executed:

#!/bin/bash
set -euo pipefail

echo "1) Find any stale references to v1.9.3"
rg -n --hidden --glob '!**/node_modules/**' --glob '!**/dist/**' $'v1\\.9\\.3' || true

echo
echo "2) Inspect values.yaml for image tag defaults (null/pinned) and repository"
fd -a values.yaml | xargs -I{} sh -c 'echo "--- {} ---"; rg -n -A2 -B2 -e "image:|repository:|tag:" "{}" || true'

echo
echo "3) Inspect templates for usage of .Chart.AppVersion and image.tag"
rg -n --hidden --glob '!**/node_modules/**' --glob '!**/dist/**' -e '\.Chart\.AppVersion|image\.tag|image:' charts/openfga/templates || true

Length of output: 2383


🌐 Web query:

OpenFGA v1.9.4 release notes or changelog: Are there any chart-impacting changes (new flags, env vars, ports, breaking changes) between v1.9.3 and v1.9.4?

💡 Result:

Short answer: I can’t find a v1.9.4 release — as of Aug 13, 2025 the latest published tag/release is v1.9.3 (released Aug 11, 2025). Therefore there are no changes to report between v1.9.3 → v1.9.4 because v1.9.4 does not appear to exist yet. (github.com)

What I checked

If you want

  • I can re-check (and diff v1.9.3 → v1.9.4) as soon as v1.9.4 is published and call out any chart-impacting items (new CLI flags, env vars, ports, or breaking changes). Would you like me to monitor the repo and notify you when v1.9.4 appears?

Citations:


Action Required: Confirm or Correct OpenFGA v1.9.4 Release

  • No stale references to v1.9.3 were found in the repo.
  • charts/openfga/values.yaml sets image.tag: "", falling back to .Chart.AppVersion.
  • All templates correctly reference .Values.image.tag | default .Chart.AppVersion.
  • GitHub Releases and the OpenFGA CHANGELOG show v1.9.3 as the latest; v1.9.4 does not appear to exist.

Please verify that v1.9.4 has been published. If it hasn’t, revert appVersion in charts/openfga/Chart.yaml to v1.9.3 (and bump again once v1.9.4 is officially released).

🤖 Prompt for AI Agents
In charts/openfga/Chart.yaml around lines 6-7 the appVersion is set to "v1.9.4"
but upstream releases and the CHANGELOG show v1.9.3 as the latest; verify
whether OpenFGA v1.9.4 is actually published, and if it is not, change
appVersion back to "v1.9.3" (then re-bump later when v1.9.4 is officially
released); keep values.yaml using image.tag: "" so templates continue to default
to .Chart.AppVersion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Release 0.2.40 (most probably) breaks OIDC authentication

3 participants