-
Notifications
You must be signed in to change notification settings - Fork 70
feat: Add HTML support in explanation #295
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add HTML support in explanation #295
Conversation
Thanks for the pull request, @abodacs! Please note that it may take us up to several weeks or months to complete a review and merge your PR. Feel free to add as much of the following information to the ticket as you can:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here. Please let us know once your PR is ready for our review and all tests are green. |
Thanks for the pull request, @abodacs! Please note that it may take us up to several weeks or months to complete a review and merge your PR. Feel free to add as much of the following information to the ticket as you can:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here. Please let us know once your PR is ready for our review and all tests are green. |
@abodacs Thanks for the PR, we will be waiting for the CLA check to go green first. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@abodacs Looks close to being done. Thank you for your patience. I have added a couple of suggestions. I will add my approval once those are addressed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@abodacs 👍
- I tested this: Entered HTML in the explanation box and verified that it renders properly in the window
- I read through the code
- I checked for accessibility issues
- Includes documentation - NA
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This one looks mostly good. I left few small comments.
@natabene, would you like to take a look at this before we merge it? |
@Agrendalath I personally don't, but maybe @jmbowman wants. |
`ReplaceURLService` replaced deprecated runtime methods in Nutmeg: openedx/edx-platform#29880
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
- I tested this: checked that explanations render HTML correctly; verified Maple and Master compatibility
- I read through the code
- I checked for accessibility issues: n/a
- Includes documentation: n/a
- I made sure any change in configuration variables is reflected in the corresponding client's
configuration-secure
repository: n/a
Mostly to trigger the CI.
Did this change consider implications for cross-site scripting (XSS)? If we're adding HTML support we should ensure that we're not creating an XSS issues. There are some useful docs here. |
@abodacs 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future. |
@abodacs 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future. |
Description
This PR adds HTML support in explanations within DnDv2
After:

Supporting information
OpenCraft internal ticket : BB-6630
Testing instructions
pip install -e .
Test HTML 12m<sup>2</sup>
Deadline
"None"