-
Notifications
You must be signed in to change notification settings - Fork 259
Create app.installation.id
attribute
#1897
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
trask
merged 29 commits into
open-telemetry:main
from
bencehornak:device-id-vs-installation-id
Mar 25, 2025
Merged
Changes from 4 commits
Commits
Show all changes
29 commits
Select commit
Hold shift + click to select a range
5176337
Create installation.id, redefine device.id
bencehornak 1997457
Add entry to schema-next
bencehornak 606df0e
Add changelog entry
bencehornak 30f369b
Update GH templates
bencehornak 01cb310
Improve language, remove same vendor comment
bencehornak be11f06
Relax MUST to SHOULD
bencehornak bdb3175
Improve language
bencehornak 9aa23c7
Remove PII notice from installation.id
bencehornak 1661c60
Revert schema-next.yaml change
bencehornak be512a1
Explicitly point out PII information
bencehornak 6e57e18
Change reference to absolute one
bencehornak 962777a
Merge remote-tracking branch 'origin/main' into device-id-vs-installa…
bencehornak 0ac6308
Add note about alternative installation.id implementations
bencehornak 7bf94ad
Revert prefix idea
bencehornak 922bbfa
Rename attribute to `app.installation.id`
bencehornak 9389e2c
Merge remote-tracking branch 'origin/main' into device-id-vs-installa…
bencehornak b1ca8d5
Move device.id changes to a separate PR
bencehornak 34207c3
Rename directory in CODEOWNERS too
bencehornak fd2e226
Make adjustments based on @bidetofevil's comment
bencehornak 76ce4ba
Update changelog entry
bencehornak 374884c
Merge branch 'main' into device-id-vs-installation-id
breedx-splk edd83f8
Merge branch 'main' into device-id-vs-installation-id
breedx-splk 0d2f2b3
Add note about app upgrades
bencehornak 79c88d5
Add note about multiple OTel SDKs in an app
bencehornak c93b2d6
Change sentence to introduce Android examples
bencehornak 5792fcd
Improve language
bencehornak c5c583b
Improve description of app attributes
bencehornak 06320f0
Merge branch 'main' into device-id-vs-installation-id
joaopgrassi 325a7c2
Merge branch 'main' into device-id-vs-installation-id
joaopgrassi File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,22 @@ | ||
# Use this changelog template to create an entry for release notes. | ||
# | ||
# If your change doesn't affect end users you should instead start | ||
# your pull request title with [chore] or use the "Skip Changelog" label. | ||
|
||
# One of 'breaking', 'deprecation', 'new_component', 'enhancement', 'bug_fix' | ||
change_type: enhancement | ||
|
||
# The name of the area of concern in the attributes-registry, (e.g. http, cloud, db) | ||
component: device | ||
|
||
# A brief description of the change. Surround your text with quotes ("") if it needs to start with a backtick (`). | ||
note: Create `installation.id` and change the definition of `device.id` | ||
|
||
# Mandatory: One or more tracking issues related to the change. You can use the PR number here if no issue exists. | ||
# The values here must be integers. | ||
issues: [1874, 1897] | ||
|
||
# (Optional) One or more lines of additional information to render under the primary note. | ||
# These lines will be padded with 2 spaces and then inserted directly into the document. | ||
# Use pipe (|) for multiline entries. | ||
subtext: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -60,6 +60,7 @@ body: | |
- area:heroku | ||
- area:host | ||
- area:http | ||
- area:installation | ||
- area:jvm | ||
- area:k8s | ||
- area:linux | ||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -52,6 +52,7 @@ body: | |
- area:heroku | ||
- area:host | ||
- area:http | ||
- area:installation | ||
- area:jvm | ||
- area:k8s | ||
- area:linux | ||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,36 @@ | ||
<!-- NOTE: THIS FILE IS AUTOGENERATED. DO NOT EDIT BY HAND. --> | ||
<!-- see templates/registry/markdown/attribute_namespace.md.j2 --> | ||
|
||
# Installation | ||
|
||
## Installation Attributes | ||
|
||
Describes installation attributes. | ||
|
||
| Attribute | Type | Description | Examples | Stability | | ||
|---|---|---|---|---| | ||
| <a id="installation-id" href="#installation-id">`installation.id`</a> | string | A unique identifier representing the installation of an application on a specific device [1] | `identifier_for_vendor:2ab2916d-a51f-4ac8-80ee-45ac31a28092`; `firebase:2ab2916d-a51f-4ac8-80ee-45ac31a28092`; `guid:2ab2916d-a51f-4ac8-80ee-45ac31a28092`; `app_set_id:2ab2916d-a51f-4ac8-80ee-45ac31a28092`; `android_id:2ab2916d-a51f-4ac8-80ee-45ac31a28092` |  | | ||
|
||
**[1] `installation.id`:** Its value MUST remain the same between launches of the same installation of an application. | ||
On a particular device it MIGHT be the same across different applications of the same vendor, however, it MUST be different across applications of different vendors. | ||
bencehornak marked this conversation as resolved.
Show resolved
Hide resolved
|
||
It SHOULD change if the application is uninstalled or if all applications of the vendor are uninstalled. | ||
bencehornak marked this conversation as resolved.
Show resolved
Hide resolved
|
||
Hardware IDs (e.g. serial number, IMEI, MAC address) MUST NOT be used as the installation identifier. | ||
The `installation.id` SHOULD be prefixed with the type of the identifier and a colon separator (e.g. `firebase:`). | ||
bencehornak marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
||
On iOS this value SHOULD be equal to the [vendor identifier](https://developer.apple.com/documentation/uikit/uidevice/identifierforvendor). | ||
|
||
On Android this value SHOULD be equal to either: | ||
|
||
- [Firebase Installation ID](https://firebase.google.com/docs/projects/manage-installations). | ||
- A globally unique UUID which is persisted across sessions in your application. | ||
|
||
But it MAY be equal to other identifiers such as: | ||
|
||
- [App set ID](https://developer.android.com/identity/app-set-id). | ||
- [`Settings.getString(Settings.Secure.ANDROID_ID)`](https://developer.android.com/reference/android/provider/Settings.Secure#ANDROID_ID). | ||
|
||
More information about Android identifier best practices can be found [here](https://developer.android.com/training/articles/user-data-ids). | ||
|
||
> [!WARNING] | ||
> | ||
> Caution should be taken when storing personal data or anything which can identify a user. GDPR and laws may apply, ensure you do your own due diligence. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,43 @@ | ||
groups: | ||
- id: registry.installation | ||
type: attribute_group | ||
display_name: Installation Attributes | ||
brief: > | ||
Describes installation attributes. | ||
stability: development | ||
attributes: | ||
- id: installation.id | ||
type: string | ||
stability: development | ||
brief: > | ||
A unique identifier representing the installation of an application on a specific device | ||
bencehornak marked this conversation as resolved.
Show resolved
Hide resolved
|
||
note: | | ||
Its value MUST remain the same between launches of the same installation of an application. | ||
bencehornak marked this conversation as resolved.
Show resolved
Hide resolved
|
||
On a particular device it MIGHT be the same across different applications of the same vendor, however, it MUST be different across applications of different vendors. | ||
bencehornak marked this conversation as resolved.
Show resolved
Hide resolved
|
||
It SHOULD change if the application is uninstalled or if all applications of the vendor are uninstalled. | ||
Hardware IDs (e.g. serial number, IMEI, MAC address) MUST NOT be used as the installation identifier. | ||
The `installation.id` SHOULD be prefixed with the type of the identifier and a colon separator (e.g. `firebase:`). | ||
bencehornak marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
||
On iOS this value SHOULD be equal to the [vendor identifier](https://developer.apple.com/documentation/uikit/uidevice/identifierforvendor). | ||
|
||
On Android this value SHOULD be equal to either: | ||
bencehornak marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
||
- [Firebase Installation ID](https://firebase.google.com/docs/projects/manage-installations). | ||
- A globally unique UUID which is persisted across sessions in your application. | ||
|
||
But it MAY be equal to other identifiers such as: | ||
|
||
- [App set ID](https://developer.android.com/identity/app-set-id). | ||
- [`Settings.getString(Settings.Secure.ANDROID_ID)`](https://developer.android.com/reference/android/provider/Settings.Secure#ANDROID_ID). | ||
|
||
More information about Android identifier best practices can be found [here](https://developer.android.com/training/articles/user-data-ids). | ||
|
||
> [!WARNING] | ||
> | ||
> Caution should be taken when storing personal data or anything which can identify a user. GDPR and laws may apply, ensure you do your own due diligence. | ||
bencehornak marked this conversation as resolved.
Show resolved
Hide resolved
|
||
examples: | ||
- identifier_for_vendor:2ab2916d-a51f-4ac8-80ee-45ac31a28092 | ||
- firebase:2ab2916d-a51f-4ac8-80ee-45ac31a28092 | ||
- guid:2ab2916d-a51f-4ac8-80ee-45ac31a28092 | ||
- app_set_id:2ab2916d-a51f-4ac8-80ee-45ac31a28092 | ||
- android_id:2ab2916d-a51f-4ac8-80ee-45ac31a28092 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,9 @@ | ||
groups: | ||
- id: resource.installation | ||
type: resource | ||
stability: development | ||
name: installation | ||
brief: > | ||
The installation of the application represented by this resource on a specific device. | ||
attributes: | ||
- ref: installation.id |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.