Set the default balancer name to round_robin #36
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lquerel
reviewed
Aug 31, 2023
jmacd
commented
Aug 31, 2023
| // which is not great for OTel Arrow exporters | ||
| // because it concentrates load at a single | ||
| // destination. | ||
| BalancerName: "round_robin", |
There was a problem hiding this comment.
This is the actual change. When the empty string is passed for BalancerName, gRPC ends up deciding pick_first in current collector builds, which ends up creating a bunch of streams to the same destination. I'll look into whether there are any popular client-side load balancers we should consider.
There was a problem hiding this comment.
Merged
jmacd
added a commit
that referenced
this pull request
Aug 31, 2023
Release v0.3.0 includes: - #24 - #29 - #30 - #36 This release includes a BREAKING CHANGE 🛑 🛑 🛑 🛑 🛑. We do not anticipate another of these, it merely renames/enumbers status codes to match the gRPC status code numbering scheme. However, since status code 0 stays the same, it will result in unusual looking errors but should be safe to deploy the receivers first. Their CANCELED (i.e., SERVER_SHUTDOWN) will read as UNAVAILABLE, etc. See #27.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here at Lightstep we think that round_robin is a reasonably good default load balancer for OTel Arrow, while
pick_firstis what we get without setting something in this field.pick_firstis not a reasonably good default load balancer for OTel Arrow. This change was documented in #29 already.Fixes #32.