Skip to content

[Rust CI] Known issues with new Rust CI jobs #317

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
2 of 4 tasks
drewrelmas opened this issue Apr 1, 2025 · 0 comments
Open
2 of 4 tasks

[Rust CI] Known issues with new Rust CI jobs #317

drewrelmas opened this issue Apr 1, 2025 · 0 comments
Labels
pipeline Rust Pipeline Related Tasks rust Pull requests that update Rust code

Comments

@drewrelmas
Copy link
Contributor

drewrelmas commented Apr 1, 2025 •
edited
Loading

After some recent additions of Rust code to the repository, there are some issues flagged by cargo deny and clippy in the new CI.

To help burndown these issues, there are 3 sub-issues opened:

It is currently expected for the cargo_deny jobs to fail both in PR and main branch until these issues are fully resolved.

The clippy job passes, but ideally it should break the build on any detected problems.

In addition, there is a known issue in the otel-arrow-rust subfolder causing fmt and test_and_coverage jobs to fail:
@jmacd jmacd pinned this issue Apr 1, 2025
@drewrelmas drewrelmas changed the title [Rust CI] Known issues with cargo_deny jobs on new Rust projects [Rust CI] Known issues with cargo_deny and clippy jobs on new Rust projects Apr 1, 2025
This was referenced Apr 1, 2025
Closed
Merged
@drewrelmas drewrelmas mentioned this issue Apr 1, 2025
Merged
jmacd added a commit that referenced this issue Apr 1, 2025
@drewrelmas @jmacd
Isolate Go and Rust CIs by file path (#318)
8dd8949 
Since #317 forecasts ongoing Rust-CI failures for the foreseeable
future, it is convenient to only run Rust CI when the git diff actually
touches something under the `rust/` directory (and vice-versa for the Go
CI).

This will be a little cleaner in the future if all Go code is isolated
under a `go/` directory. For now, the Go-CI will run if something
outside of `rust/` is touched.

Will also help in cases like #311 which only touch Go code - hiding
unrelated job failures.

Co-authored-by: Joshua MacDonald <[email protected]>
@lquerel lquerel added pipeline Rust Pipeline Related Tasks rust Pull requests that update Rust code labels Apr 16, 2025
@drewrelmas drewrelmas mentioned this issue Apr 23, 2025
Merged
@drewrelmas drewrelmas mentioned this issue May 6, 2025
Merged
@drewrelmas drewrelmas changed the title [Rust CI] Known issues with cargo_deny and clippy jobs on new Rust projects [Rust CI] Known issues with new Rust CI jobs May 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
pipeline Rust Pipeline Related Tasks rust Pull requests that update Rust code
Projects
OTel-Arrow
Status: No status
Milestone
No milestone
Development

No branches or pull requests
2 participants
@lquerel @drewrelmas