Skip to content

fix(span_processor): only call on_start with recording spans #3011

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

paullegranddc
Copy link
Contributor

@paullegranddc paullegranddc commented May 30, 2025

Issue

SpanProcessor API refactor #2940

Changes

According to the spec, spans that are not recording should not be passed to span processors.
https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/trace/sdk.md#recording-sampled-reaction-table

This PR fixes this interaction.

Merge requirement checklist

  • CONTRIBUTING guidelines followed
  • Unit tests added/updated (if applicable)
  • Appropriate CHANGELOG.md files updated for non-trivial, user-facing changes
  • Changes in public API reviewed (if applicable)

According to the spec, spans that are not recording should not be passed to span processors.
@paullegranddc paullegranddc requested a review from a team as a code owner May 30, 2025 12:20
Copy link

codecov bot commented May 30, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.0%. Comparing base (8882c31) to head (159e336).
Report is 2 commits behind head on main.

Additional details and impacted files
@@          Coverage Diff          @@
##            main   #3011   +/-   ##
=====================================
  Coverage   81.0%   81.0%           
=====================================
  Files        126     126           
  Lines      24753   24755    +2     
=====================================
+ Hits       20070   20072    +2     
  Misses      4683    4683           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@cijothomas cijothomas merged commit 167c946 into open-telemetry:main May 30, 2025
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants