Skip to content

Promote the operator.collector.targetallocatorcr feature flag to Beta #3965

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 30, 2025

Conversation

swiatekm
Copy link
Contributor

@swiatekm swiatekm commented May 1, 2025

Description:
As a result of this change, when the target allocator section is enabled in the Collector CR, this now creates a TargetAllocator CR instead of generating the manifests directly. Behavior should otherwise be unchanged.

Link to tracking Issue(s):

#2422

Testing:
Tests already exists for this behaviour. We simply stop running them with it disabled.

swiatekm added 2 commits May 28, 2025 17:31
As a result of this change, when the target allocator section is enabled
in the Collector CR, this now creates a TargetAllocator CR instead of
generating the manifests directly. Behavior should otherwise be
unchanged.
@swiatekm swiatekm force-pushed the feat/enable-collector-tacr branch from eae72e2 to d299ca5 Compare May 28, 2025 15:35
@swiatekm swiatekm marked this pull request as ready for review May 28, 2025 16:32
@swiatekm swiatekm requested a review from a team as a code owner May 28, 2025 16:32
Copy link
Contributor

@jaronoff97 jaronoff97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

our e2e tests cover the result of this already right? im 99% sure the answer is yes but just want to confirm my understanding

@swiatekm
Copy link
Contributor Author

our e2e tests cover the result of this already right? im 99% sure the answer is yes but just want to confirm my understanding

Yes, this PR simply stops running them with the flag off. We were running them with it on for some time now, and continue to do so.

@swiatekm swiatekm merged commit fb121a1 into open-telemetry:main May 30, 2025
46 of 47 checks passed
atoulme pushed a commit to atoulme/opentelemetry-operator that referenced this pull request Jun 2, 2025
…ta (open-telemetry#3965)

* Promote the operator.collector.targetallocatorcr feature flag to Beta

As a result of this change, when the target allocator section is enabled
in the Collector CR, this now creates a TargetAllocator CR instead of
generating the manifests directly. Behavior should otherwise be
unchanged.

* Fix unit tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants