Allow setting target allocator via label #3411
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swiatekm
force-pushed
the
feat/ta-crd-label
branch
from
856dc8e to
2553634
Compare
jaronoff97
reviewed
Oct 30, 2024
jaronoff97
approved these changes
Nov 5, 2024
Starefossen
pushed a commit
to Starefossen/opentelemetry-operator
that referenced
this pull request
Apr 10, 2025
* Allow setting target allocator via label * Move label definition to constants package * Fix context handling in collector webhook build validator
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Allow connecting the OpenTelemetryCollector and TargetAllocator CRs by setting a label on the Collector CR.
Link to tracking Issue(s):
Testing:
Added some basic unit tests and an e2e test showing how label changes affect the Collector manifests.