Skip to content

Conversation

@cjihrig
Copy link
Contributor

@cjihrig cjihrig commented Oct 30, 2025

Which problem is this PR solving?

Some of the sdk-node tests currently clean up their modified environment variables at the end of each test. This is unreliable because if a given test fails, the clean up code is not run, and can leak environment variables into surrounding tests.

I believe this is the last file with this problem, so this should conclude the process.env cleanup PRs.

Fixes # N/A

Short description of the changes

This commit updates the appropriate tests to ensure that modified environment variables are cleaned up between tests.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

  • Existing test suite

Checklist:

  • Followed the style guidelines of this project
  • Unit tests have been added
  • Documentation has been updated

@cjihrig cjihrig requested a review from a team as a code owner October 30, 2025 15:39
@codecov
Copy link

codecov bot commented Oct 30, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.16%. Comparing base (c358db1) to head (d52dc0f).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6066   +/-   ##
=======================================
  Coverage   95.16%   95.16%           
=======================================
  Files         316      316           
  Lines        9207     9207           
  Branches     2075     2075           
=======================================
  Hits         8762     8762           
  Misses        445      445           
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

@JacksonWeber JacksonWeber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and thank you for helping improve the test reliability.

@maryliag maryliag added this pull request to the merge queue Nov 3, 2025
Merged via the queue into open-telemetry:main with commit f37e648 Nov 3, 2025
27 checks passed
@otelbot
Copy link
Contributor

otelbot bot commented Nov 3, 2025

Thank you for your contribution @cjihrig! 🎉 We would like to hear from you about your experience contributing to OpenTelemetry by taking a few minutes to fill out this survey.

@cjihrig cjihrig deleted the process-env branch November 3, 2025 02:59
@otelbot-js otelbot-js bot mentioned this pull request Nov 3, 2025
maryliag pushed a commit to maryliag/opentelemetry-js that referenced this pull request Nov 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants