Skip to content

Conversation

@pichlermarc
Copy link
Member

Which problem is this PR solving?

We can't checkout using a token when we don't don't have the token yet.

@pichlermarc pichlermarc requested a review from a team as a code owner October 16, 2025 12:17
@codecov
Copy link

codecov bot commented Oct 16, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.99%. Comparing base (471b411) to head (9ec7b71).
⚠️ Report is 5 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6018   +/-   ##
=======================================
  Coverage   94.99%   94.99%           
=======================================
  Files         313      313           
  Lines        8775     8775           
  Branches     1884     1884           
=======================================
  Hits         8336     8336           
  Misses        439      439           
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

@maryliag maryliag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

create one PR of each possible order, one of them must be right 😅

@pichlermarc
Copy link
Member Author

create one PR of each possible order, one of them must be right 😅

exactly what I'm thinking.

@pichlermarc pichlermarc added this pull request to the merge queue Oct 17, 2025
Merged via the queue into open-telemetry:main with commit a93b1dc Oct 17, 2025
25 of 26 checks passed
@pichlermarc pichlermarc deleted the chore/create-token-before-checkout branch October 17, 2025 12:03
maryliag pushed a commit to maryliag/opentelemetry-js that referenced this pull request Oct 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants