Skip to content

[WIP] entities prototype #5620

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

dyladan
Copy link
Member

@dyladan dyladan commented Apr 18, 2025

Pulls in changes from the first prototype and applies them to the 2.0 SDK

TODO:

  • tests
  • add entity detectors (process/host probably a good start)
  • Make Entity a type/interface instead of a class because it is accessed from resource.entities
  • Export pipeline

Open questions:

  • Should detectors be able to detect resource attributes and entities, or just one or the other
  • verify entity merge override ordering because it's the opposite of the current resource impl

dyladan added 2 commits April 18, 2025 15:10
Pulls in changes from the first prototype and applies them to the 2.0 SDK

TODO: tests, entity detectors
Copy link

codecov bot commented Apr 21, 2025

Codecov Report

Attention: Patch coverage is 26.78571% with 82 lines in your changes missing coverage. Please review.

Project coverage is 94.07%. Comparing base (dbbd032) to head (73de5fb).
Report is 14 commits behind head on main.

Files with missing lines Patch % Lines
...ackages/opentelemetry-resources/src/entity-impl.ts 9.45% 67 Missing ⚠️
...kages/opentelemetry-resources/src/resource-impl.ts 59.45% 15 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5620      +/-   ##
==========================================
- Coverage   94.92%   94.07%   -0.85%     
==========================================
  Files         310      311       +1     
  Lines        7953     8047      +94     
  Branches     1605     1631      +26     
==========================================
+ Hits         7549     7570      +21     
- Misses        404      477      +73     
Files with missing lines Coverage Δ
...es/opentelemetry-resources/src/detect-resources.ts 78.57% <100.00%> (ø)
...kages/opentelemetry-resources/src/resource-impl.ts 81.60% <59.45%> (ø)
...ackages/opentelemetry-resources/src/entity-impl.ts 9.45% <9.45%> (ø)

... and 2 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant