docs(opentelemetry-resources): fix wrong sample code in readme #2289
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
use semantic-conventions package to get ResourceAttributes in sample code
alisabzevari
requested review from
Flarna,
MSNev,
OlivierAlbertini,
dyladan,
johnbley,
legendecas,
markwolff,
mayurkale22,
mwear,
naseemkullah,
obecny and
vmarchaud
as code owners
MSNev
approved these changes
Jun 16, 2021
vmarchaud
approved these changes
Jun 17, 2021
Codecov Report
@@ Coverage Diff @@
## main #2289 +/- ##
==========================================
+ Coverage 92.70% 92.72% +0.01%
==========================================
Files 145 145
Lines 5184 5184
Branches 1060 1060
==========================================
+ Hits 4806 4807 +1
+ Misses 378 377 -1
|
obecny
approved these changes
Jun 21, 2021
dyladan
approved these changes
Jun 23, 2021
Merged
This was referenced Feb 22, 2022
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2284
Which problem is this PR solving?
opentelemetry-resourcesreadme and usesResourceAttributesfromsemantic-conventionsmodule to access the standard resource names.Short description of the changes
semantic-conventionsmodule in the sentence describing standard attributes.