chore: remove references to Noop classes from API #2230
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dyladan
requested review from
Flarna,
OlivierAlbertini,
johnbley,
legendecas,
markwolff,
mayurkale22,
mwear,
naseemkullah,
obecny and
vmarchaud
as code owners
Codecov Report
@@ Coverage Diff @@
## main #2230 +/- ##
==========================================
+ Coverage 92.23% 92.25% +0.01%
==========================================
Files 143 143
Lines 5154 5154
Branches 1060 1060
==========================================
+ Hits 4754 4755 +1
+ Misses 400 399 -1
|
vmarchaud
approved these changes
May 26, 2021
Flarna
approved these changes
May 26, 2021
obecny
reviewed
May 26, 2021
Member
obecny
left a comment
obecny
left a comment
There was a problem hiding this comment.
one question towards type, the rest lgtm
obecny
approved these changes
May 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only references from the production API package were changed. The metrics API can be handled at a later time. They were only used in tests so this is pretty straightforward.