feat(opentelemetry-instrumentation): getConfig and setConfig #2224
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mottibec
requested review from
Flarna,
OlivierAlbertini,
dyladan,
johnbley,
legendecas,
markwolff,
mayurkale22,
mwear,
naseemkullah,
obecny and
vmarchaud
as code owners
mottibec
changed the title
vmarchaud
reviewed
May 23, 2021
vmarchaud
approved these changes
May 23, 2021
Codecov Report
@@ Coverage Diff @@
## main #2224 +/- ##
=======================================
Coverage 92.71% 92.72%
=======================================
Files 142 142
Lines 5120 5124 +4
Branches 1049 1050 +1
=======================================
+ Hits 4747 4751 +4
Misses 373 373
|
rauno56
approved these changes
May 24, 2021
dyladan
approved these changes
May 24, 2021
weyert
approved these changes
May 24, 2021
obecny
reviewed
May 24, 2021
packages/opentelemetry-instrumentation/test/common/Instrumentation.test.ts
Outdated
Show resolved
Hide resolved
packages/opentelemetry-instrumentation/test/common/Instrumentation.test.ts
Outdated
Show resolved
Hide resolved
packages/opentelemetry-instrumentation/test/common/Instrumentation.test.ts
Outdated
Show resolved
Hide resolved
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Plugins should be able to modify configuration at run time; many plugins implement this. There is no reason this shouldn't be in the base class, so all plugins have this functionality.
Short description of the changes
Added
getConfigandsetConfigtoInstrumentationAbstractandInstrumentationFixes #2174