semantic-conventions: include built esm files in package #2167
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t2t2
requested review from
Flarna,
OlivierAlbertini,
dyladan,
johnbley,
legendecas,
markwolff,
mayurkale22,
mwear,
naseemkullah,
obecny and
vmarchaud
as code owners
Codecov Report
@@ Coverage Diff @@
## main #2167 +/- ##
=======================================
Coverage 92.80% 92.80%
=======================================
Files 140 140
Lines 5002 5002
Branches 1029 1029
=======================================
Hits 4642 4642
Misses 360 360 |
dyladan
changed the title
Member
|
edit: removed feat also. this isn't really a feature either |
dyladan
changed the title
dyladan
approved these changes
Apr 28, 2021
Flarna
reviewed
Apr 28, 2021
vmarchaud
approved these changes
Apr 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
While testing ESM in contrib (open-telemetry/opentelemetry-js-contrib#459) I noticed webpack was still using cjs files for
@opentelemetry/semantic-conventions, turns out I missed including esm files for this one package in #2112 and webpack was tolerant enough to not warn about itShort description of the changes
Include esm files in packed
@opentelemetry/semantic-conventions