feat: handle OTEL_TRACES_SAMPLER env var #2111
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds support for OTEL_TRACES_SAMPLER and OTEL_TRACES_SAMPLER_ARG, in favor of OTEL_SAMPLING_PROBABILITY.
jtmalinowski
requested review from
Flarna,
OlivierAlbertini,
dyladan,
johnbley,
legendecas,
markwolff,
mayurkale22,
mwear,
naseemkullah,
obecny and
vmarchaud
as code owners
Codecov Report
@@ Coverage Diff @@
## main #2111 +/- ##
==========================================
- Coverage 92.73% 92.64% -0.09%
==========================================
Files 138 139 +1
Lines 4927 4964 +37
Branches 1016 1026 +10
==========================================
+ Hits 4569 4599 +30
- Misses 358 365 +7
|
Member
|
lgtm, but could you mark this as breaking and add documentation as how to migrate form If I understand correctly it would be: old: new: |
Member
I've already added the "breaking" label which should generated the correct entry in the changelog |
Contributor
Author
|
@naseemkullah @vmarchaud fixed |
vmarchaud
approved these changes
Apr 15, 2021
naseemkullah
approved these changes
Apr 15, 2021
obecny
reviewed
Apr 16, 2021
Member
obecny
left a comment
obecny
left a comment
There was a problem hiding this comment.
generally ok, just one concern with the hardcoded values, please create enum / const for that
Contributor
Author
|
@obecny done, let me know if we need anything else |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for OTEL_TRACES_SAMPLER and OTEL_TRACES_SAMPLER_ARG, in favor of
OTEL_SAMPLING_PROBABILITY.
Which problem is this PR solving?
Short description of the changes
OTEL_SAMPLING_PROBABILITYOTEL_TRACES_SAMPLERandOTEL_TRACES_SAMPLER_ARG