fix(http-instrumentation): crash fix #2009
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nirsky
requested review from
Flarna,
OlivierAlbertini,
dyladan,
johnbley,
legendecas,
markwolff,
mayurkale22,
mwear,
naseemkullah,
obecny and
vmarchaud
as code owners
Codecov Report
@@ Coverage Diff @@
## main #2009 +/- ##
=======================================
Coverage 92.92% 92.92%
=======================================
Files 152 152
Lines 5924 5924
Branches 1245 1245
=======================================
Hits 5505 5505
Misses 419 419
|
vmarchaud
approved these changes
Mar 11, 2021
naseemkullah
approved these changes
Mar 11, 2021
Member
naseemkullah
left a comment
naseemkullah
left a comment
There was a problem hiding this comment.
lgtm but would be nice to add a test or comment since TS does not catch this
johnbley
approved these changes
Mar 11, 2021
Contributor
Author
|
Added a test |
obecny
approved these changes
Mar 11, 2021
dyladan
approved these changes
Mar 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Short description of the changes
constructor.name, in case object doesn't have a custructor.