chore: fixing path of instrumentation file for different systems #1999
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
obecny
requested review from
Flarna,
OlivierAlbertini,
dyladan,
johnbley,
legendecas,
markwolff,
mayurkale22,
mwear,
naseemkullah and
vmarchaud
as code owners
Codecov Report
@@ Coverage Diff @@
## main #1999 +/- ##
==========================================
+ Coverage 92.92% 92.97% +0.05%
==========================================
Files 152 152
Lines 5924 5925 +1
Branches 1245 1245
==========================================
+ Hits 5505 5509 +4
+ Misses 419 416 -3
|
vmarchaud
approved these changes
Mar 9, 2021
Member
vmarchaud
left a comment
vmarchaud
left a comment
There was a problem hiding this comment.
lgtm, i think we should look into running tests on windows so we can catch issues like that later on
Flarna
approved these changes
Mar 9, 2021
MSNev
approved these changes
Mar 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Short description of the changes