Skip to content

feat(semantic-conventions): add missing RpcAttributes from spec #1976

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dyladan merged 2 commits into from
Mar 2, 2021
Merged

feat(semantic-conventions): add missing RpcAttributes from spec #1976

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
05394cb
feat(semantic-conventions): add missing RpcAttributes from spec
blumamir Feb 28, 2021
0fe01f4
Merge branch 'main' into rpc-semantic-conventions
dyladan Mar 2, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 22 additions & 0 deletions packages/opentelemetry-semantic-conventions/src/trace/rpc.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,30 @@
* limitations under the License.
*/
export const RpcAttribute = {
/**
* A string identifying the remoting system.
*
* @remarks
* Required
*/
RPC_SYSTEM: 'rpc.system',

/**
* The full name of the service being called, including its package name, if applicable.
*
* @remarks
* Not required, but recommended
*/
RPC_SERVICE: 'rpc.service',

/**
* The name of the method being called, must be equal to the $method part in the span name.
*
* @remarks
* Not required, but recommended
*/
RPC_METHOD: 'rpc.method',

// GRPC (no spec)
GRPC_KIND: 'grpc.kind', // SERVER or CLIENT
GRPC_METHOD: 'grpc.method',
Expand Down