chore: pin API and move it to peer dependency #491
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
move API to a peer dependency like in core repo. Additionally pin API as rc releases tend to be breaking.
naseemkullah
approved these changes
May 19, 2021
Codecov Report
@@ Coverage Diff @@
## main #491 +/- ##
==========================================
- Coverage 95.26% 95.21% -0.05%
==========================================
Files 140 137 -3
Lines 8399 8291 -108
Branches 815 791 -24
==========================================
- Hits 8001 7894 -107
+ Misses 398 397 -1
|
blumamir
approved these changes
May 19, 2021
Member
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
move API to a peer dependency like in core repo.
Additionally pin API as rc releases tend to be breaking.
Refs: open-telemetry/opentelemetry-js#2074
Refs: open-telemetry/opentelemetry-js#2213