Instrument bedrock InvokeModelWithResponseStream #13607
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anuraaga
commented
Mar 28, 2025
| @@ -89,28 +89,6 @@ | |||
| <property name="tokens" | |||
| value="LITERAL_DO, LITERAL_ELSE, LITERAL_FOR, LITERAL_IF, LITERAL_WHILE"/> | |||
| </module> | |||
| <module name="LeftCurly"> | |||
There was a problem hiding this comment.
This checkstyle rule conflicts with spotless formatting of case blocks. I just removed it, and perhaps other formatting-related ones can be removed as well later since they're at best redundant with spotless and at worse may conflict.
laurit
reviewed
Apr 7, 2025
| } else if (requestModel.startsWith("amazon.nova")) { | ||
| handleEventAmazonNova(result); | ||
| } else if (requestModel.startsWith("anthropic.claude")) { | ||
| handleEventAnthropicCloud(result); |
laurit
approved these changes
Apr 7, 2025
…nstrumentation into bedrock-invoke-model-stream
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the streaming version of
InvokeModel. After this, there's one PR left to add support for tools withInvokeModel*and the bedrock instrumentation should be complete./cc @codefromthecrypt