-
Notifications
You must be signed in to change notification settings - Fork 959
Update Pulsar semantic #13578
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Update Pulsar semantic #13578
Conversation
…nstrumentation/api/incubator/semconv/messaging/MessagingMetricsAdvice.java Co-authored-by: Lauri Tulmin <[email protected]>
…nstrumentation/api/incubator/semconv/messaging/MessagingProducerMetrics.java Co-authored-by: Lauri Tulmin <[email protected]>
…nstrumentation/api/incubator/semconv/messaging/MessagingProducerMetricsTest.java Co-authored-by: Steve Rao <[email protected]>
…nstrumentation/api/incubator/semconv/messaging/MessagingProducerMetricsTest.java Co-authored-by: Steve Rao <[email protected]>
The linked document starts with the following warning
Note that there is also #13192 |
@laurit Thank you for your reminder. I've noticed that quite a bit of time has passed since this PR was created, and there is still no stable release. Do you recommend enabling compatibility at this stage? If we enable it, it will modify modules like Alternatively, we could maintain the current situation and make changes when the stable version is released. I look forward to your suggestions. |
No, you should follow the same approach as http and db semantic convention stabilization efforts. Modify the extractors so that by default nothing changes and only emit the new attributes when semconv stability flag is used. In tests have a separate suite that runs with |
@laurit Thank you for the suggestion. I will create a new PR to address the compatibility issues, and I will follow up on the current PR once it is merged. |
Reference document: https://opentelemetry.io/docs/specs/semconv/messaging/messaging-metrics/