Skip to content

Remove UrlInstrumentation. #1059

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Aug 20, 2020
Merged

Remove UrlInstrumentation. #1059

merged 3 commits into from
Aug 20, 2020

Conversation

dengliming
Copy link
Member

closes #1045

trask
trask reviewed Aug 19, 2020
View reviewed changes
Copy link
Member

@trask trask left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can keep UrlConnectionTest with this one test:

def "trace request with connection failure #scheme"()

It really tests the underlying HttpURLConnection instrumentation (but still makes sense in class named UrlConnectionTest)

@dengliming
Merge remote-tracking branch 'upstream/master' into remove_urlinstrum…
2089483 
…entation

# Conflicts:
#	instrumentation/http-url-connection/src/main/java/io/opentelemetry/instrumentation/auto/httpurlconnection/UrlInstrumentation.java
@dengliming
Fix review
8d941c0
@anuraaga
Copy link
Contributor

Thanks!

trask
trask approved these changes Aug 20, 2020
View reviewed changes
Copy link
Member

@trask trask left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@trask trask merged commit 41bf322 into open-telemetry:master Aug 20, 2020
schmikei pushed a commit to schmikei/opentelemetry-java-instrumentation that referenced this pull request Apr 17, 2025
@karthikscale3 @joaopgrassi @nirga
Add additional LLM span attributes (open-telemetry#1059)
82c0926 
Co-authored-by: Joao Grassi <[email protected]>
Co-authored-by: Liudmila Molkova <[email protected]>
Co-authored-by: Nir Gazit <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anuraaga anuraaga anuraaga approved these changes

@trask trask trask approved these changes

@iNikem iNikem Awaiting requested review from iNikem

@jkwatson jkwatson Awaiting requested review from jkwatson

@tylerbenson tylerbenson Awaiting requested review from tylerbenson

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove UrlInstrumentation
3 participants
@dengliming @anuraaga @trask