Skip to content

Fix label selector in operator NOTES.txt template #1684

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 30, 2025
Merged

Fix label selector in operator NOTES.txt template #1684

merged 2 commits into from
May 30, 2025

Conversation

ababila
Copy link
Contributor

@ababila ababila commented May 24, 2025 •
edited
Loading

This tiny PR fixes the kubectl get pods command to use the correct label selector app.kubernetes.io/instance instead of app.kubernetes.io/name

@ababila ababila requested review from Allex1, jvoravong and a team as code owners May 24, 2025 19:51
@linux-foundation-easycla Linux Foundation: EasyCLA
Copy link

linux-foundation-easycla bot commented May 24, 2025 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

@ababila ababila changed the title Fix typo in operator NOTES.txt template Fix label selector in operator NOTES.txt template May 25, 2025
TylerHelmuth
TylerHelmuth reviewed May 27, 2025
View reviewed changes
Copy link
Member

@TylerHelmuth TylerHelmuth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please bump the chart's patch version and then run make generate-examples CHARTS=opentelemetry-operator

@ababila
Copy link
Contributor Author

ababila commented May 28, 2025

please bump the chart's patch version and then run make generate-examples CHARTS=opentelemetry-operator

Hello ,
Done!
patch version updated

@ababila ababila requested review from dmitryax and povilasv as code owners May 28, 2025 16:02
@ababila ababila requested a review from TylerHelmuth May 28, 2025 16:14
@jaronoff97
Copy link
Contributor

@ababila this is great thanks! Youll need to rebase when you get a chance, a PR was just merged that bumps to 0.90.1, so youll need to go to 0.90.2 and re-run the make

@ababila
Copy link
Contributor Author

ababila commented May 30, 2025

0.90.2 and re-run the make

okay, done.

@TylerHelmuth TylerHelmuth merged commit d8fe1d2 into open-telemetry:main May 30, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaronoff97 jaronoff97 jaronoff97 approved these changes

@TylerHelmuth TylerHelmuth TylerHelmuth approved these changes

@Allex1 Allex1 Awaiting requested review from Allex1 Allex1 is a code owner

@jvoravong jvoravong Awaiting requested review from jvoravong jvoravong is a code owner

@dmitryax dmitryax Awaiting requested review from dmitryax

@povilasv povilasv Awaiting requested review from povilasv

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ababila @jaronoff97 @TylerHelmuth