Skip to content

Remove prometheus legacy validation warning #6590

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Apr 9, 2025

Conversation

dmathieu
Copy link
Member

@dmathieu dmathieu commented Apr 2, 2025

I have been chatting with @bwplotka, who wouldn't recommend removing the support for the legacy scheme now.

Indeed, some system don't support the new scheme yet (such as cortex).
So removing this will entirely prevent those users form upgrading their SDK.

They are going to remove the deprecation from the legacy method on common, at least until the new scheme can be used in enough systems.

@dmathieu dmathieu marked this pull request as ready for review April 2, 2025 08:55
Copy link
Member

@XSAM XSAM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dmathieu
Copy link
Member Author

dmathieu commented Apr 2, 2025

Good catch. I've changed the wording to say we'll be removing it in a future release, not the next one.

@dmathieu dmathieu merged commit 9d8b616 into open-telemetry:main Apr 9, 2025
29 checks passed
@dmathieu dmathieu deleted the remove-legacy-warning branch April 9, 2025 07:17
@bwplotka
Copy link

bwplotka commented Apr 9, 2025

Thanks makes sense. Do you still need us to remove the "Deprecate" mark from related common code pieces?

We chatted a bit on KubeCon indeed and you mentioned that common pieces marked as "deprecate" is somehow blocking Otel Go SDK from using this functionality in a new stable version. I am trying to unpack that blocker, are you worried that deprecated entry AND the fact common is 0.x version increase risk of this functionality to be removed soon from common? I think it's a valid fear, which might be also "fixed" by committing to common v1 or vendoring core common pieces in client golang. Feel free to give us feedback on this issue!

cc @dmathieu

@dmathieu
Copy link
Member Author

dmathieu commented Apr 9, 2025

I think you can keep your deprecation.

We don't necessarily look at dependencies stability. If something is marked as deprecated, that's a sign for us that we don't want to use it. Especially if we're not stable on our end.
But as this PR shows, we're open to keeping deprecated things if that's warranted.

I guess the question now for us is what would be the signal indicating we can start looking into removing support for this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants