Skip to content

Fix close stale value to be relative #6451

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 17, 2025

Conversation

dmathieu
Copy link
Member

It appears the close value is relative to the issue being marked as stale.
Which makes sense. Marking as stale updates the issue, so we'd have to wait for 2 more years before closing.

This is the core equivalent of open-telemetry/opentelemetry-go-contrib#6943

@dmathieu dmathieu added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Mar 17, 2025
@dmathieu dmathieu marked this pull request as ready for review March 17, 2025 10:55
Copy link

codecov bot commented Mar 17, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.8%. Comparing base (0997b5f) to head (f1366c3).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##            main   #6451     +/-   ##
=======================================
- Coverage   81.8%   81.8%   -0.1%     
=======================================
  Files        283     283             
  Lines      24910   24910             
=======================================
- Hits       20383   20382      -1     
- Misses      4122    4123      +1     
  Partials     405     405             

see 2 files with indirect coverage changes

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dmathieu
Copy link
Member Author

Merging as a trivial PR

@dmathieu dmathieu merged commit 2e8d5a9 into open-telemetry:main Mar 17, 2025
31 of 32 checks passed
@MrAlias MrAlias added this to the v1.36.0 milestone Mar 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants