Skip to content

log: Add missing notice to Bytes, Slice, Map doc comment #5598

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 11, 2024
Merged

log: Add missing notice to Bytes, Slice, Map doc comment #5598

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d7171de
log: Add missing notice to Bytes, Slice, Map doc comment
pellared Jul 10, 2024
594e719
Merge branch 'main' into add-kv-missing-comments
pellared Jul 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions log/keyvalue.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -351,16 +351,19 @@ func Bool(key string, value bool) KeyValue {
}

// Bytes returns a KeyValue for a []byte value.
// The passed slice must not be changed after it is passed.
func Bytes(key string, value []byte) KeyValue {
return KeyValue{key, BytesValue(value)}
}

// Slice returns a KeyValue for a []Value value.
// The passed slice must not be changed after it is passed.
func Slice(key string, value ...Value) KeyValue {
return KeyValue{key, SliceValue(value...)}
}

// Map returns a KeyValue for a map value.
// The passed slice must not be changed after it is passed.
func Map(key string, value ...KeyValue) KeyValue {
return KeyValue{key, MapValue(value...)}
}
Expand Down