Skip to content

otelzap: Implement Uint methods on encoder #5609

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
May 21, 2024
Merged

otelzap: Implement Uint methods on encoder #5609

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
b796f0f
Add catalog-info.yaml config file
khushijain21 Mar 18, 2024
57df264
Merge pull request #1 from khushijain21/backstage-integration
khushijain21 Mar 18, 2024
0055aeb
Merge branch 'open-telemetry:main' into main
khushijain21 May 6, 2024
bc6132d
otelzap: Implement Uint methods on encoder
khushijain21 May 19, 2024
36a7031
add more test case
khushijain21 May 20, 2024
e61a9bd
Merge branch 'main' into encoderuint
khushijain21 May 20, 2024
faca44e
Update bridges/otelzap/encoder_test.go
pellared May 20, 2024
148391c
Merge branch 'main' of https://github.com/khushijain21/opentelemetry-…
khushijain21 May 20, 2024
7349412
Merge branch 'encoderuint' of https://github.com/khushijain21/opentel…
khushijain21 May 20, 2024
703aa2e
Merge branch 'main' of https://github.com/open-telemetry/opentelemetr…
khushijain21 May 20, 2024
dc59470
added test case for Uint
khushijain21 May 20, 2024
163e46d
Merge branch 'main' into encoderuint
pellared May 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions bridges/otelzap/encoder_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,6 +79,11 @@ func TestObjectEncoder(t *testing.T) {
},
{
desc: "AddUint64",
f: func(e zapcore.ObjectEncoder) { e.AddUint64("k", 42) },
expected: int64(42),
},
{
desc: "AddUint64 (Overflow case)",
f: func(e zapcore.ObjectEncoder) { e.AddUint64("k", ^uint64(0)) },
expected: float64(^uint64(0)),
},
Expand Down