Use trace convention helpers from main otel-go repo #112
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Aneurysm9
requested review from
evantorrie,
jmacd,
lizthegrey,
MrAlias and
paivagustavo
as code owners
MrAlias
approved these changes
Jun 29, 2020
evantorrie
approved these changes
Jun 29, 2020
evantorrie
added
dependencies
plantfansam
referenced
this pull request
in plantfansam/opentelemetry-go-contrib
Mar 18, 2022
* Exporter: Initial Jaeger Trace Exporter commit. * remove unused methods and add TODOs. * remove TODO. * fix build error by exporting event struct. * move Event from basetypes.go to export.go
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #103, should only be merged after that.