Put otel meter for http/grpc behind a FF #7543
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mx-psi
requested changes
Apr 18, 2023
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #7543 +/- ##
==========================================
+ Coverage 91.18% 91.21% +0.02%
==========================================
Files 296 296
Lines 14422 14465 +43
==========================================
+ Hits 13151 13194 +43
Misses 1006 1006
Partials 265 265
☔ View full report in Codecov by Sentry. |
codeboten
reviewed
Apr 21, 2023
mx-psi
approved these changes
Apr 26, 2023
bogdandrutu
reviewed
Apr 26, 2023
jaronoff97
force-pushed
the
7517-behind-ff
branch
from
a05e7ef to
c37aad7
Compare
Aneurysm9
approved these changes
Apr 26, 2023
codeboten
approved these changes
May 1, 2023
Contributor
codeboten
left a comment
codeboten
left a comment
There was a problem hiding this comment.
Thanks for addressing my comments.
codeboten
pushed a commit
to codeboten/opentelemetry-collector
that referenced
this pull request
May 2, 2023
**Description:** Puts the grpc meter provider behind a feature flag for controlling high cardinality metrics. **Link to tracking Issue:** open-telemetry#7517
4 tasks
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: Puts the grpc meter provider behind a feature flag for controlling high cardinality metrics.
Link to tracking Issue: #7517
Testing: Tested locally and ensured the metric didn't appear when using otel metrics enabled.