Disallow dollar sign in opaque value, allow recursive expansion to be implemented in the future #6268
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportBase: 92.30% // Head: 92.30% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #6268 +/- ##
=======================================
Coverage 92.30% 92.30%
=======================================
Files 219 219
Lines 13455 13466 +11
=======================================
+ Hits 12419 12430 +11
Misses 806 806
Partials 230 230
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
bogdandrutu
force-pushed
the
invaliddollar
branch
2 times, most recently
from
200967b to
1f5c6c2
Compare
|
skip changelog since the feature is not yet enabled (if put in the changelog would cause confusion). |
bogdandrutu
added
the
Skip Changelog
bogdandrutu
force-pushed
the
invaliddollar
branch
from
1f5c6c2 to
66a62de
Compare
… implemented in the future Signed-off-by: Bogdan <[email protected]>
bogdandrutu
force-pushed
the
invaliddollar
branch
from
66a62de to
3d48fed
Compare
mx-psi
approved these changes
Oct 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates #5706