Skip to content

Remove config.[Receivers|Exporters|Processors|Extensions], use map directly #4344

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 2, 2021

Conversation

bogdandrutu
Copy link
Member

Signed-off-by: Bogdan Drutu [email protected]

@bogdandrutu bogdandrutu requested review from a team and owais November 2, 2021 22:07
@codecov
Copy link

codecov bot commented Nov 2, 2021

Codecov Report

Merging #4344 (0bd76c7) into main (9cdb1da) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4344      +/-   ##
==========================================
- Coverage   87.25%   87.25%   -0.01%     
==========================================
  Files         177      177              
  Lines       10585    10581       -4     
==========================================
- Hits         9236     9232       -4     
  Misses       1107     1107              
  Partials      242      242              
Impacted Files Coverage Δ
config/config.go 100.00% <ø> (ø)
config/exporter.go 88.88% <ø> (ø)
config/extension.go 88.88% <ø> (ø)
config/processor.go 88.88% <ø> (ø)
config/receiver.go 88.88% <ø> (ø)
config/configunmarshaler/defaultunmarshaler.go 100.00% <100.00%> (ø)
exporter/exporterhelper/factory.go 100.00% <0.00%> (ø)
receiver/receiverhelper/factory.go 100.00% <0.00%> (ø)
extension/extensionhelper/factory.go 81.25% <0.00%> (ø)
processor/batchprocessor/splitlogs.go 100.00% <0.00%> (ø)
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9cdb1da...0bd76c7. Read the comment docs.

@dmitryax
Copy link
Member

dmitryax commented Nov 2, 2021

Why we want this to be removed?

@bogdandrutu
Copy link
Member Author

@dmitryax smaller public API, also easier to read the Config struct I believe.

@bogdandrutu bogdandrutu merged commit aea73f8 into open-telemetry:main Nov 2, 2021
@bogdandrutu bogdandrutu deleted the maptypes branch November 2, 2021 23:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants