Skip to content

Remove config.Pipeline.Name, already in the Piplines map key #4326

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 2, 2021

Conversation

bogdandrutu
Copy link
Member

Signed-off-by: Bogdan Drutu [email protected]

@bogdandrutu bogdandrutu requested review from a team and dmitryax October 30, 2021 00:53
@codecov
Copy link

codecov bot commented Oct 30, 2021

Codecov Report

Merging #4326 (96c4d70) into main (a81963f) will increase coverage by 0.00%.
The diff coverage is 94.44%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #4326   +/-   ##
=======================================
  Coverage   87.24%   87.25%           
=======================================
  Files         177      177           
  Lines       10586    10585    -1     
=======================================
  Hits         9236     9236           
+ Misses       1108     1107    -1     
  Partials      242      242           
Impacted Files Coverage Δ
config/configunmarshaler/defaultunmarshaler.go 100.00% <ø> (ø)
config/service.go 100.00% <ø> (ø)
service/internal/builder/receivers_builder.go 73.60% <66.66%> (+0.37%) ⬆️
service/internal/builder/pipelines_builder.go 87.42% <93.75%> (+0.07%) ⬆️
config/config.go 100.00% <100.00%> (ø)
service/internal/builder/exporters_builder.go 91.50% <100.00%> (ø)
service/zpages.go 80.19% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a81963f...96c4d70. Read the comment docs.

Copy link
Contributor

@codeboten codeboten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please resolve the conflict.

Copy link
Contributor

@codeboten codeboten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for addressing my comments

@bogdandrutu bogdandrutu merged commit c32554a into open-telemetry:main Nov 2, 2021
@bogdandrutu bogdandrutu deleted the rmcfgpipename branch November 2, 2021 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants