Remove squash on configtls.TLSClientSetting in confighttp & cnofiggrpc
#4063
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mxiamxia
force-pushed
the
tls_config
branch
from
9e27b34 to
4607209
Compare
Aneurysm9
approved these changes
Sep 16, 2021
bogdandrutu
reviewed
Sep 17, 2021
mxiamxia
force-pushed
the
tls_config
branch
from
1a710a4 to
d8f22ee
Compare
commit 4607209 Author: Min Xia <[email protected]> Date: Thu Sep 16 13:33:52 2021 -0700 Do not squash `configtls.TLSClientSetting` in `confighttp` and `cnofiggrpc` config
mxiamxia
force-pushed
the
tls_config
branch
from
d8f22ee to
81d67a3
Compare
codeboten
approved these changes
Sep 17, 2021
Contributor
codeboten
left a comment
codeboten
left a comment
There was a problem hiding this comment.
This is a great improvement 👍
bogdandrutu
approved these changes
Sep 20, 2021
|
|
||
| // TLSSetting struct exposes TLS client configuration. | ||
| TLSSetting configtls.TLSClientSetting `mapstructure:",squash"` | ||
| TLSSetting configtls.TLSClientSetting `mapstructure:"tls,omitempty"` |
Member
There was a problem hiding this comment.
Do we need to use a pointer to determine when the config is set at all?
bbeattie-phxlabs
added a commit
to bbeattie-phxlabs/opentelemetry-helm-charts
that referenced
this pull request
Sep 22, 2021
New location for `insecure` as per open-telemetry/opentelemetry-collector#4063
6 tasks
tigrannajaryan
pushed a commit
that referenced
this pull request
Sep 27, 2021
Change TLSClient config to pointer type in `confighttp` and `configgrpc` config **Related Issue** #4028 #4063 (comment)
This was referenced Oct 19, 2021
This was referenced Jan 11, 2022
tgross
pushed a commit
to hashicorp/nomad-open-telemetry-getting-started
that referenced
this pull request
Jan 11, 2022
This fixes a key error parsing config files introduced by a breaking change in open-telemetry/opentelemetry-collector#4063
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: <Describe what has changed.
Remove the squash for
configtls.TLSClientSettinginconfighttpandcnofiggrpcper discussion - #4028TODO: Fix
contribtests for the breaking changesLink to tracking Issue:
#4028