Refactor config: pipelines now under service #376
Conversation
pjanotti
requested review from
bogdandrutu,
flands,
owais,
songy23 and
tigrannajaryan
as code owners
tigrannajaryan
left a comment
tigrannajaryan
left a comment
There was a problem hiding this comment.
LGTM.
I was scared of the number of changed files, but it is mostly test data. :-)
ccaraman
left a comment
ccaraman
left a comment
There was a problem hiding this comment.
Should we change the term 'service' in the config to collector to be in line with the renaming?
Codecov ReportAll modified and coverable lines are covered by tests ✅
❌ Your project status has failed because the head coverage (74.81%) is below the target coverage (90.00%). You can increase the head coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## master #376 +/- ##
=======================================
Coverage 74.81% 74.81%
=======================================
Files 115 115
Lines 6885 6885
=======================================
Hits 5151 5151
Misses 1478 1478
Partials 256 256 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This change moves 'pipelines' sections from the top level to under the 'service' section.
pjanotti
force-pushed
the
refactor-service-config
branch
from
19c3195 to
01a370d
Compare
|
@ccaraman regarding
See the discussion at #346 (comment) basically it is the "service provide by the collector" |
Signed-off-by: jcheng-splunk <[email protected]>
6 participants
This change moves 'pipelines' sections from the top level to under the 'service' section.
Fixes #346