Skip to content

Refactor ConfigValidator #2856

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
bogdandrutu merged 1 commit into from
Mar 30, 2021
Merged

Refactor ConfigValidator #2856

bogdandrutu merged 1 commit into from
Mar 30, 2021

Conversation

@bogdandrutu
Copy link
Member

@bogdandrutu bogdandrutu commented Mar 30, 2021 •
edited
Loading

Followup after #2802

Signed-off-by: Bogdan Drutu [email protected]

@bogdandrutu bogdandrutu requested a review from a team March 30, 2021 17:41
@bogdandrutu
Copy link
Member Author

bogdandrutu commented Mar 30, 2021

/cc @mxiamxia @mx-psi

bogdandrutu
bogdandrutu commented Mar 30, 2021
View reviewed changes
@codecov
Copy link

codecov bot commented Mar 30, 2021 •
edited
Loading

Codecov Report

Merging #2856 (464a2a6) into main (2c17034) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2856      +/-   ##
==========================================
- Coverage   91.77%   91.77%   -0.01%     
==========================================
  Files         286      286              
  Lines       15159    15158       -1     
==========================================
- Hits        13912    13911       -1     
  Misses        853      853              
  Partials      394      394
Impacted Files Coverage Δ
config/receiver.go 100.00% <ø> (ø)
receiver/hostmetricsreceiver/config.go 100.00% <ø> (ø)
receiver/jaegerreceiver/config.go 100.00% <ø> (ø)
receiver/kafkareceiver/config.go 100.00% <ø> (ø)
receiver/opencensusreceiver/config.go 80.00% <ø> (ø)
receiver/otlpreceiver/config.go 100.00% <ø> (ø)
receiver/prometheusreceiver/config.go 100.00% <ø> (ø)
receiver/zipkinreceiver/config.go 100.00% <ø> (ø)
component/componenttest/nop_receiver.go 100.00% <100.00%> (ø)
config/config.go 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2c17034...464a2a6. Read the comment docs.

mx-psi
mx-psi approved these changes Mar 30, 2021
View reviewed changes
Copy link
Member

@mx-psi mx-psi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@mx-psi
Copy link
Member

mx-psi commented Mar 30, 2021

The expected error on line 144 from config/config_test.go should be changed to fix the failing unit test

@bogdandrutu bogdandrutu reopened this Mar 30, 2021
tigrannajaryan
tigrannajaryan approved these changes Mar 30, 2021
View reviewed changes
Copy link
Member

@tigrannajaryan tigrannajaryan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally LGTM with minor comments.

@bogdandrutu
Refactor ConfigValidator
464a2a6 
Signed-off-by: Bogdan Drutu <[email protected]>
@bogdandrutu bogdandrutu merged commit 2605ec4 into open-telemetry:main Mar 30, 2021
@bogdandrutu bogdandrutu deleted the configvalidate branch March 30, 2021 22:18
pjanotti pushed a commit to pjanotti/opentelemetry-service that referenced this pull request Apr 6, 2021
@bogdandrutu @pjanotti
Refactor ConfigValidator (open-telemetry#2856)
0c37b68 
Signed-off-by: Bogdan Drutu <[email protected]>
@mxiamxia mxiamxia mentioned this pull request Apr 7, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tigrannajaryan tigrannajaryan tigrannajaryan approved these changes

@mx-psi mx-psi mx-psi approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@bogdandrutu @mx-psi @tigrannajaryan