Skip to content

Rename [Start|End]Time to [Start|End]Timestamp in pdata #2847

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 31, 2021
Merged

Rename [Start|End]Time to [Start|End]Timestamp in pdata #2847

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@

## 🛑 Breaking changes 🛑

- Rename pdata.*.[Start|End]Time to pdata.*.[Start|End]Timestamp (#2847)
- Rename pdata.DoubleExemplar to pdata.Exemplar (#2804)
- Rename pdata.DoubleHistogram to pdata.Histogram (#2797)
- Rename pdata.DoubleSummary to pdata.Summary (#2774)
Expand Down
4 changes: 2 additions & 2 deletions cmd/pdatagen/internal/common_structs.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,7 @@ var instrumentationLibraryField = &messageValueField{
}

var startTimeField = &primitiveTypedField{
fieldName: "StartTime",
fieldName: "StartTimestamp",
originFieldName: "StartTimeUnixNano",
returnType: "Timestamp",
rawType: "uint64",
Expand All @@ -91,7 +91,7 @@ var timeField = &primitiveTypedField{
}

var endTimeField = &primitiveTypedField{
fieldName: "EndTime",
fieldName: "EndTimestamp",
originFieldName: "EndTimeUnixNano",
returnType: "Timestamp",
rawType: "uint64",
Expand Down
50 changes: 25 additions & 25 deletions consumer/pdata/generated_metrics.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

60 changes: 30 additions & 30 deletions consumer/pdata/generated_metrics_test.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

20 changes: 10 additions & 10 deletions consumer/pdata/generated_trace.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

24 changes: 12 additions & 12 deletions consumer/pdata/generated_trace_test.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading