hostmetricsreceiver: (network/paging/process) Refactor to use metrics metadata #2421
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #2421 +/- ##
==========================================
- Coverage 91.88% 91.80% -0.08%
==========================================
Files 268 264 -4
Lines 15213 15073 -140
==========================================
- Hits 13978 13838 -140
Misses 857 857
Partials 378 378
Continue to review full report at Codecov.
|
asuresh4
force-pushed
the
paging-metadata
branch
from
cc2ae6b to
c98e2aa
Compare
asuresh4
force-pushed
the
paging-metadata
branch
from
c98e2aa to
5218465
Compare
asuresh4
changed the title
asuresh4
force-pushed
the
paging-metadata
branch
from
5218465 to
e83edad
Compare
jrcamp
reviewed
Feb 1, 2021
Contributor
jrcamp
left a comment
jrcamp
left a comment
There was a problem hiding this comment.
Ideally only tests would use New()
receiver/hostmetricsreceiver/internal/scraper/networkscraper/network_scraper.go
Outdated
Show resolved
Hide resolved
receiver/hostmetricsreceiver/internal/scraper/processscraper/process_scraper.go
Outdated
Show resolved
Hide resolved
jrcamp
approved these changes
Feb 1, 2021
tigrannajaryan
approved these changes
Feb 8, 2021
Member
tigrannajaryan
left a comment
tigrannajaryan
left a comment
There was a problem hiding this comment.
LGTM. Refactored while keeping current emitted metrics.
This was referenced Mar 8, 2021
Troels51
pushed a commit
to Troels51/opentelemetry-collector
that referenced
this pull request
Jul 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #2406
Refactor network, paging, process and processes scrapers to use metrics metadata utility.