Add external labels to prometheus remote write exporter #2044
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2044 +/- ##
==========================================
- Coverage 91.94% 91.92% -0.02%
==========================================
Files 279 279
Lines 16706 16724 +18
==========================================
+ Hits 15360 15374 +14
- Misses 926 928 +2
- Partials 420 422 +2
Continue to review full report at Codecov.
|
added 2 commits
October 30, 2020 21:32
bogdandrutu
reviewed
Nov 3, 2020
bogdandrutu
reviewed
Nov 3, 2020
bogdandrutu
approved these changes
Nov 3, 2020
bogdandrutu
approved these changes
Nov 3, 2020
hughesjj
pushed a commit
to hughesjj/opentelemetry-collector
that referenced
this pull request
Apr 27, 2023
…0220906165146-f3363e06e74c (open-telemetry#2044)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR adds the concept of Prometheus "external labels" to the Prometheus Remote Write Exporter. These labels must be kept isolated from OTLP metric data point labels because they do not undergo the same type of sanitization. The difference is external labels are allowed to start with "__". This satisfies the use case of Cortex HA deduplication and hence resolves the linked issue.
Link to tracking Issue: #1892
Testing:
Unit test cases have been added wherever changes were made and manual testing was done to verify Cortex HA deduplication and that nothing changed in metric graphs other than labels.
Documentation:
The example configuration in testdata/config.yaml demonstrates how to use the external label config'
README has been updated to include external label config
-- cc @alolita