Remove StringValue, do not return a pointer to the value in the map #2021
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is important since we changed to use slice of values instead of slice of pointers. After that change we returned a pointer to the memory block to allow users to change the value of the returned Get or when ForEach, this has a problem if the user keeps a reference to the returned value by the Get call, then applies any mutation that may move the memory around Delete, Insert/Upsert the returned pointer may point to other block of memory (different value in the map) or to a block that is no longer part of the slice, if the slice has to be moved. Signed-off-by: Bogdan Drutu <[email protected]>
bogdandrutu
force-pushed
the
rmstringvalue
branch
from
ca4c48f to
b2fda98
Compare
Codecov Report
@@ Coverage Diff @@
## master #2021 +/- ##
==========================================
+ Coverage 91.87% 91.88% +0.01%
==========================================
Files 276 276
Lines 16495 16495
==========================================
+ Hits 15155 15157 +2
+ Misses 923 922 -1
+ Partials 417 416 -1
Continue to review full report at Codecov.
|
Member
tigrannajaryan
left a comment
tigrannajaryan
left a comment
There was a problem hiding this comment.
LGTM. Do we have a similar problem with AttributeValue?
Member
Author
|
@tigrannajaryan yes, and you saw that in the contrib when I moved the delete, will try to find a solution for the AttributeValue |
tigrannajaryan
approved these changes
Oct 29, 2020
Troels51
pushed a commit
to Troels51/opentelemetry-collector
that referenced
this pull request
Jul 5, 2024
Co-authored-by: Lalit Kumar Bhasin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is important since we changed to use slice of values instead of slice of pointers.
After that change we returned a pointer to the memory block to allow users to change the value
of the returned Get or when ForEach, this has a problem if the user keeps a reference to
the returned value by the Get call, then applies any mutation that may move the memory around
Delete, Insert/Upsert the returned pointer may point to other block of memory (different
value in the map) or to a block that is no longer part of the slice, if the slice has to be moved.