Logging Exporter: Add index for histogram buckets count #2009
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JasonXZLiu
changed the title
Codecov Report
@@ Coverage Diff @@
## master #2009 +/- ##
=======================================
Coverage 91.50% 91.50%
=======================================
Files 282 282
Lines 16628 16628
=======================================
Hits 15216 15216
Misses 977 977
Partials 435 435
Continue to review full report at Codecov.
|
bogdandrutu
reviewed
Oct 26, 2020
bogdandrutu
approved these changes
Oct 26, 2020
MovieStoreGuy
pushed a commit
to atlassian-forks/opentelemetry-collector
that referenced
this pull request
Nov 11, 2021
* Ensure that no-op tracer still progates non-recording spans Signed-off-by: Anthony J Mirabella <[email protected]> * Add `TracerProvider` to the `trace.Span` interface Signed-off-by: Anthony J Mirabella <[email protected]> * Remove config from oteltest.Tracer as it can be accessed through the provider Signed-off-by: Anthony J Mirabella <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR was introduced to fix the logging exporter to increment the histogram bucket labels (when logging out metrics). Previously, the bucket count stayed at 0. However, bucket labels should increment to conform with the Explicit Bound labels.
Related issue: #2008