Update filter processor to use pdata #1885
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1885 +/- ##
==========================================
+ Coverage 91.30% 91.34% +0.03%
==========================================
Files 280 281 +1
Lines 16628 16687 +59
==========================================
+ Hits 15183 15242 +59
Misses 1011 1011
Partials 434 434
Continue to review full report at Codecov.
|
pmcollins
requested review from
bogdandrutu,
dmitryax,
james-bebbington,
nilebox,
owais,
pjanotti and
tigrannajaryan
as code owners
pmcollins
commented
Oct 1, 2020
bogdandrutu
reviewed
Oct 1, 2020
Member
Nice 😄 |
bogdandrutu
approved these changes
Oct 5, 2020
Member
bogdandrutu
left a comment
bogdandrutu
left a comment
There was a problem hiding this comment.
This is a good solution for the moment, we should maybe think in the future to add helpers filter[Metrics|Logs|Spans] in the future that allows to do this in-place.
hughesjj
pushed a commit
to hughesjj/opentelemetry-collector
that referenced
this pull request
Apr 27, 2023
Troels51
pushed a commit
to Troels51/opentelemetry-collector
that referenced
this pull request
Jul 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated filter processor to use pdata rather than OC. There's still some OC stuff in filter_processor_test.go, but am hoping that can be updated in a separate change.
Also replaced a benchmark test with a new one. (The previous benchmark test failed with a nil pointer.) The new benchmark test has the following results:
4233112 ns/op before this change
837378 ns/op after this change