Skip creation of redundant nil resource in translation from OC if there are no combined metrics #1803
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: Getting rid of redundant nil
ResourceObjectwhen all metrics have resource specified.After removal of
pdatautilpackage in #1739, I've migrated our custom components frompdatautil.MetricsFromMetricsDatatointernaldata.OCToMetricsand found that some tests are failing due to converted metrics having an extra "empty"ResourceMetricsobject in the slice.Testing: Added unit test reproducing the issue
/cc @bogdandrutu