-
Notifications
You must be signed in to change notification settings - Fork 1.8k
[mdatagen] Enable configurable attributes for metrics #14281
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Codecov Report❌ Patch coverage is ❌ Your patch check has failed because the patch coverage (56.22%) is below the target coverage (95.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #14281 +/- ##
==========================================
- Coverage 92.15% 91.39% -0.76%
==========================================
Files 668 668
Lines 41517 42287 +770
==========================================
+ Hits 38258 38649 +391
- Misses 2221 2560 +339
- Partials 1038 1078 +40 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
CodSpeed Performance ReportMerging #14281 will not alter performanceComparing
|
Reopens 13900
Description
Modified
cmd/mdatagento allow for two new fields in the configuration yaml of metrics. These new configuration options will allow for a user to enable or disable attributes (i.e. reduce dimensionality of metrics being generated) from their collector configuration. The modifiedMetricsBuildergenerated bymdatagendoes not record disabled attributes and automatically re-aggregates metrics based on the resulting enabled set of attributes. There are four different aggregation strategies supported (sum, average, min, and max) which can be specified as a setting inconfig.yaml.The changes to the config.yaml are:
Attribute
requirement_leveltakes president over this re-aggregation and any metric attribute with arequirement_levelofrequiredcannot be disabled in this way. For more information onrequirement_levelplease see 13913The set of attributes provided by the user must be contained in the set of attributes defined in the metadata.yaml, including an attribute which is not defined in the metrics
metadatafile will fail. Also, attempting to omit an attribute defined asrequirement_level: requiredwill cause the configuration to fail and the collector not to start. Omitting the field entirely will default to the defined set of metric attributes in themetadatafile with a requirement level ofrecommendedor above.Link to tracking issue
Fixes 10726
Testing
Generated tests have been updated to test new aggregation behavior.
Documentation
ran
make gogenerateran
make generate